test: migrate stats/base/dists/pareto-type1/logpdf to ULP-based assertions - #14842
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
@stdlib/stats/base/dists/pareto-type1/logpdffrom relative-tolerance testing to ULP (units in the last place) difference testing, per the tracking issue.delta/tol(EPS-based) comparisons intest/test.logpdf.js,test/test.native.js, andtest/test.factory.jswitht.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ).1) was determined by measuring the actual ULP difference between the computed and expected values across all three fixture sets (large_alpha,large_beta,both_large); the measured maximum ULP difference was0(exact matches) for the JavaScript, factory, and native implementations, so1is used as the tightest bound with a minimal safety margin. Verified deterministic across two full test runs, including the native addon (built locally for verification).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, which selected the candidate package, studied prior-art conversions referenced in #11352, applied the
isAlmostSameValuemigration, and measured the minimum ULP bound against the fixtures.@stdlib-js/reviewers
Generated by Claude Code